[App Config] az appconfig create/update: Add developer sku support#31199
Merged
zhoxing-ms merged 6 commits intoAzure:devfrom Apr 16, 2025
Merged
[App Config] az appconfig create/update: Add developer sku support#31199zhoxing-ms merged 6 commits intoAzure:devfrom
az appconfig create/update: Add developer sku support#31199zhoxing-ms merged 6 commits intoAzure:devfrom
Conversation
ChristineWanjau
requested review from
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| appconfig create | cmd appconfig create update parameter sku: updated property choices from ['Free', 'Premium', 'Standard'] to ['Developer', 'Free', 'Premium', 'Standard'] |
||
| appconfig update | cmd appconfig update update parameter sku: updated property choices from ['Free', 'Premium', 'Standard'] to ['Developer', 'Free', 'Premium', 'Standard'] |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
avanigupta and
yonzhan
microsoft-github-policy-service
bot
added
App Configuration
Auto-Assign
ChristineWanjau
changed the title
az appconfig create/update : Add developer sku supportaz appconfig create/update : Add developer sku support
ChristineWanjau
changed the title
az appconfig create/update : Add developer sku supportaz appconfig create/update : Add developer sku support
ChristineWanjau
changed the title
az appconfig create/update : Add developer sku supportaz appconfig create/update: Add developer sku support
albertofori
reviewed
Apr 9, 2025
Contributor
There was a problem hiding this comment.
Not related to this PR but it appears this warning misses private_network_access
Contributor
Author
There was a problem hiding this comment.
I also can't see this property in our commands https://learn.microsoft.com/en-us/cli/azure/appconfig?view=azure-cli-latest#az-appconfig-create
Contributor
There was a problem hiding this comment.
Sorry I was talking about enable_arm_private_network_access?
Contributor
Author
There was a problem hiding this comment.
I see, just updated the warning
albertofori
approved these changes
Apr 15, 2025
Contributor
Author
|
@zhoxing-ms This PR is ready to merge. |
zhoxing-ms
approved these changes
Apr 16, 2025
zhoxing-ms
changed the title
az appconfig create/update: Add developer sku supportaz appconfig create/update: Add developer sku support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az appconfig create
az appconfig update
Description
This PR adds developer sku support
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.